dongjoon-hyun opened a new pull request, #59595:
URL: https://github.com/apache/spark/pull/59595

   ### What changes were proposed in this pull request?
   
   This PR aims to respect the UI root (`spark.ui.proxyBase`, 
`APPLICATION_WEB_PROXY_BASE`, or the Knox `X-Forwarded-Context` header) in the 
Master UI links, like SPARK-60311 did in the History Server log page.
   
   - `MasterPage`: The `Environment` and `Log` links use 
`UIUtils.prependBaseUri`.
   - `EnvironmentPage` and `LogPage`: The `Back to Master` links use 
`UIUtils.prependBaseUri`.
   
   ### Why are the changes needed?
   
   Under a UI root, e.g., behind a front-end reverse proxy with a path 
(`spark.ui.reverseProxyUrl`) or Knox, these links go outside of the UI root and 
don't work. This bug exists since Apache Spark 
[v4.0.0](https://github.com/apache/spark/releases/tag/v4.0.0) (2025-05-19), 
which added the Master log page (SPARK-46870) and environment page 
(SPARK-47894).
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, the `Environment`, `Log`, and `Back to Master` links work under a UI 
root. There is no change when the UI root is empty (default).
   
   ### How was this patch tested?
   
   Pass the CIs with the updated `MasterWorkerUISuite`, which fails without 
this fix. `MasterSuiteBase.verifyStaticResourcesServedByProxy` now checks all 
site-relative links, not only `/static`, and the test applies it to the Master 
`Environment` and `Log` pages too.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to