rdtr commented on code in PR #59425:
URL: https://github.com/apache/spark/pull/59425#discussion_r4319132201
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -3198,6 +3203,29 @@ class SparkConnectPlanner(
}
}
+ /**
+ * Walks the relation tree and applies
[[PipelinesHandler.blockUnsupportedSqlCommand]] to every
+ * component that would be executed by [[executeSQLWithRefs]] or
[[executeSQL]] at the normal
+ * path. For a valid SQL-with-references [[proto.WithRelations]], the root
SQL is parsed
+ * (without execution) and each reference's input is inspected recursively
so nested
+ * [[proto.WithRelations]] cannot re-trigger the executing transformation
chain. For other
+ * relation types, [[transformRelation]] produces an unresolved plan without
side effects and is
Review Comment:
Thanks, fixed in d4ed446e83. The comments now cover only the top-level and
direct-reference cases, and the scaladoc notes the wrapped case as a known
limitation. I updated the PR description too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
