peter-toth commented on code in PR #59599:
URL: https://github.com/apache/spark/pull/59599#discussion_r4339248494
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/KeyGroupedPartitionedScan.scala:
##########
@@ -154,7 +196,9 @@ trait KeyGroupedPartitionedScan[T] {
// Now fill missing partition keys with empty partitions
val partitionMapping = nestGroupedPartitions.toMap
- spjParams.commonPartitionValues.get.flatMap {
+ val commonPartValues = projectCommonPartitionValuesIfNeeded(
Review Comment:
**Finding 10.** This repeats the projection already computed as
`commonPartValuesForGrouping` at L166, with the same arguments. Reusing that
value avoids projecting every common value twice.
---
_Generated by [Claude Code](https://claude.ai/code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
