eason-yuchen-liu commented on code in PR #59621:
URL: https://github.com/apache/spark/pull/59621#discussion_r4340671706
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala:
##########
@@ -1425,7 +1425,10 @@ abstract class StreamingOuterJoinBase extends
StreamingJoinSuite {
assertNumStateRows(total = 7, updated = 2),
AddData(rightInput, (0, 30)), // watermark = 30 - 10 = 20,
no-data-batch computes nulls
CheckNewAnswer(outerResult),
- assertNumStateRows(total = 2, updated = 1)
+ assertNumStateRows(total = 2, updated = 1),
+ Execute { query =>
+
assert(query.recentProgress.flatMap(_.stateOperators).map(_.numRowsRemoved).sum
== 6)
Review Comment:
nit: `assertNumStateRows` already takes `removed = Some(Seq(n))`
(FlatMapGroupsWithStateSuite uses it). That checks removals per step, with
retries, instead of summing over the whole run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
