viirya opened a new pull request, #59691:
URL: https://github.com/apache/spark/pull/59691
### What changes were proposed in this pull request?
This is a branch-4.x follow-up of SPARK-59985 (#59242). It removes the
`self.assertIsNone(dist.log_streaming_auth_secret)` assertion from
`test_log_streaming_server_start_failure_warns` in
`python/pyspark/ml/torch/tests/test_distributor.py`.
`TorchDistributor.log_streaming_auth_secret` exists only on master. It was
added by 77f1e05768f ("[PYTHON][MINOR] Improve TorchDistributor log server
provisioning"), which is not on branch-4.x. When #59242 was cherry-picked onto
branch-4.x as b628a945a24, the test was taken as written for master, including
this assertion. The manual backports for 4.3/4.2/4.1/4.0 (#59381, #59382,
#59383, #59384) already leave it out. This PR makes branch-4.x match them; the
rest of the test is unchanged.
### Why are the changes needed?
On branch-4.x the test fails with:
```
AttributeError: 'TorchDistributor' object has no attribute
'log_streaming_auth_secret'
```
This breaks the PySpark CI for PRs against branch-4.x, for example #59676,
which does not touch `pyspark.ml.torch`.
### Does this PR introduce _any_ user-facing change?
No. Test-only change.
### How was this patch tested?
Ran
`TorchDistributorBaselineUnitTests.test_log_streaming_server_start_failure_warns`
locally. Before this change it fails with the `AttributeError` above; after
it, it passes. Also checked that branch-4.x has no other reference to
`log_streaming_auth_secret` under `python/`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
