dongjoon-hyun commented on code in PR #59739:
URL: https://github.com/apache/spark/pull/59739#discussion_r4360111355
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PythonPipelineSuite.scala:
##########
@@ -1632,6 +1632,12 @@ class PythonPipelineSuite
"CREATE TABLE some_table (id INT)",
"CREATE VIEW some_view AS SELECT * FROM some_table",
"INSERT INTO some_table VALUES (1)",
+ "WITH v AS (SELECT 1 AS id) INSERT INTO some_table SELECT * FROM v",
+ "WITH v AS (SELECT 1 AS id) MERGE INTO some_table t USING v ON t.id = v.id
" +
+ "WHEN MATCHED THEN DELETE",
+ "WITH v AS (SELECT 1 AS id) UPDATE some_table SET id = 2 WHERE id IN
(SELECT id FROM v)",
+ "WITH v AS (SELECT 1 AS id) DELETE FROM some_table WHERE id IN (SELECT id
FROM v)",
+ "FROM some_view INSERT INTO some_table SELECT * INSERT INTO some_new_table
SELECT *",
Review Comment:
Thank you. Right, a CTE-prefixed multi-insert,
`UnresolvedWith(Union(UnresolvedInsert, ...))`, is the only shape that needs
the recursion, and none of the new entries covered it. I added it as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
