mihailoale-db commented on code in PR #59746: URL: https://github.com/apache/spark/pull/59746#discussion_r4359077306
########## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCommandHelper.scala: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.catalyst.plans.logical.{DropView, LogicalPlan} +import org.apache.spark.sql.connector.catalog.ViewCatalog +import org.apache.spark.sql.errors.QueryCompilationErrors +import org.apache.spark.sql.execution.command.{DropTableCommand, DropTempViewCommand} + +/** + * Rewrites resolved view commands to their session-catalog commands in [[ResolveSessionCatalog]]. + * Views in a [[ViewCatalog]] keep the V2 command. + */ +object ViewCommandHelper { + + /** + * Rewrites a resolved [[DropView]] to [[DropTempViewCommand]] for a temporary view or to + * [[DropTableCommand]] for a session-catalog view. Fails for a session-catalog target whose + * namespace does not have exactly one part, and for a catalog that cannot host views. Returns + * `dropView` itself if its target is in a [[ViewCatalog]] or is not resolved. + */ + def rewrite(dropView: DropView): LogicalPlan = dropView match { + // Session-qualified temp view: same execution path as FakeSystemCatalog DROP VIEW. + case DropView(ResolvedTempView(ident, _), ifExists) => + DropTempViewCommand(ident, ifExists) + + case DropView(DropViewInSessionCatalog(ident), ifExists) => + DropTableCommand(ident, ifExists, isView = true, purge = false) + + // ViewCatalog catalogs fall through to `DataSourceV2Strategy`, which routes DROP VIEW to Review Comment: here and in other places. ########## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCommandHelper.scala: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.catalyst.plans.logical.{DropView, LogicalPlan} +import org.apache.spark.sql.connector.catalog.ViewCatalog +import org.apache.spark.sql.errors.QueryCompilationErrors +import org.apache.spark.sql.execution.command.{DropTableCommand, DropTempViewCommand} + +/** + * Rewrites resolved view commands to their session-catalog commands in [[ResolveSessionCatalog]]. + * Views in a [[ViewCatalog]] keep the V2 command. + */ +object ViewCommandHelper { + + /** + * Rewrites a resolved [[DropView]] to [[DropTempViewCommand]] for a temporary view or to + * [[DropTableCommand]] for a session-catalog view. Fails for a session-catalog target whose + * namespace does not have exactly one part, and for a catalog that cannot host views. Returns + * `dropView` itself if its target is in a [[ViewCatalog]] or is not resolved. + */ + def rewrite(dropView: DropView): LogicalPlan = dropView match { + // Session-qualified temp view: same execution path as FakeSystemCatalog DROP VIEW. + case DropView(ResolvedTempView(ident, _), ifExists) => + DropTempViewCommand(ident, ifExists) + + case DropView(DropViewInSessionCatalog(ident), ifExists) => + DropTableCommand(ident, ifExists, isView = true, purge = false) + + // ViewCatalog catalogs fall through to `DataSourceV2Strategy`, which routes DROP VIEW to Review Comment: nit: I would move all the inline comments to Scala docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
