nchammas commented on code in PR #59250:
URL: https://github.com/apache/spark/pull/59250#discussion_r4375999484
##########
dev/sparktestsupport/modules.py:
##########
@@ -166,10 +248,10 @@ def __init__(
self.build_profile_flags = build_profile_flags
self.environ = environ or {}
self.python_test_goals = python_test_goals
+ self.shell_script_test_goals = shell_script_test_goals
Review Comment:
If we really need to guard against this, I would wait for a real-world
example of it happening. Passing lists as input is standard Python, and
worrying about list mutations feels a bit overkill. After all, this code is
only called by Spark contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
