dongjoon-hyun commented on code in PR #59797:
URL: https://github.com/apache/spark/pull/59797#discussion_r4383655257
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala:
##########
@@ -293,6 +293,52 @@ abstract class FileStreamSinkSuite extends StreamTest {
}
}
+ test("SPARK-60563: Check INTERVAL and empty struct columns when starting a
query") {
+ val df = MemoryStream[Int].toDF()
+ val intervalDf = df.selectExpr("value AS i", "make_interval(0, 0, 0,
value) AS d")
Review Comment:
Thanks for the review. Addressed in adb9210bbc9. The test now also checks:
- ANSI interval types (`make_ym_interval` and `make_dt_interval` columns)
are accepted at start with Parquet, ORC, JSON, and CSV, so flipping
`forbidAnsiIntervals` would fail it.
- `toTable` into an existing table rejects a `CalendarInterval` column at
start with `UNSUPPORTED_DATA_TYPE_FOR_DATASOURCE`, so moving
`disallowWritingIntervals` under the `catalogTable.isEmpty` condition would
fail it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
