dejankrak-db commented on PR #59843: URL: https://github.com/apache/spark/pull/59843#issuecomment-6467265051
Thanks for the review. The LEFT SEMI/ANTI regression is fixed in b869b85d609 (see the inline thread). That commit also updates the docs: the `JoinResolver` class scaladoc and the `handleRegularJoin` step list now mention the top-level wrap, `retainTopLevelJoinOutput` points to `RetainsOriginalJoinOutput`, and `RetainsOriginalJoinOutput` says that `JoinResolver` wraps a top-level join itself. On the subquery question: I would keep it out of scope here. As you note, it is not a regression, since that query is analyzed exactly as before this PR. Covering it would mean deriving the check from the resolved condition's references, including outer references of subqueries, so I added it to the out-of-scope list in the description rather than widening this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
