dbtsai commented on PR #110: URL: https://github.com/apache/spark-connect-rust/pull/110#issuecomment-6480918688
@viirya — the changes from the [overall review](https://github.com/apache/spark-connect-rust/pull/110#pullrequestreview-5689065344) are in 584eaef, with individual replies on each inline comment. The new `SPARK_REMOTE`-gated `test_day_time_interval_real_server` passed against Spark 4.2.0. It covers the SQL interval literal, `make_dt_interval`, a negative value, nested struct/array/map and both iterator modes. I also checked the compiled Python drop-in against that server: exact `timedelta` results passed through `collect()` and `toLocalIterator()` with and without prefetch. Input support is deferred to [SPARK-60659](https://issues.apache.org/jira/browse/SPARK-60659), with infallible inference restored here. The description now explains NA-fill rejection, the raw-microsecond display choice and the enum compatibility impact. The remaining item is the coverage workflow's full-directory test discovery, as explained in its inline reply. The description also records the need to preserve the Duration arm and tests when integrating #112. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
