linhongliu-db commented on PR #59882: URL: https://github.com/apache/spark/pull/59882#issuecomment-6485179745
Review comments addressed; ready for another pass. [af30df7](https://github.com/apache/spark/commit/af30df77b0dc6a95ddc919d70627ea3fc42f31c0) replaces the foldability self-comparison with explicit expectations and actual ConstantFolding checks for literal and attribute inputs to to_number, try_to_number, and numeric to_char. Local SBT validation: all 79 StringExpressionsSuite tests and relevant Scala style checks passed. GitHub Build currently reports `ACTION_REQUIRED`; CI validation is still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
