srielau commented on PR #59873: URL: https://github.com/apache/spark/pull/59873#issuecomment-6488057154
Addressed the review in 2c8af4ccad9. **Context-failure qualification:** after an override cannot be applied, references stay the unqualified parse-time names. The attempted context never took effect, and qualifying in the invoker would name objects in a schema the caller explicitly overrode away from. `analyze_success` is false and the error is `INVALID_PARAMETER_VALUE.PARSE_SQL_CONTEXT`. **Isolation:** this PR still mutates the invoker session for overrides, but restore is now stored catalog/namespace/PATH/PATH-flag (no re-validation, no materializing unset keys). A per-call CatalogManager overlay remains the complete answer for concurrent USE; I would land that as a follow-up rather than add a new CatalogManager here. PARSE column-name change (`parse_sql(x)` becoming `parse_sql(x, PARSE, NULL, NULL, NULL)`) is real; I will mention it in the user-facing-change section of the PR body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
