ohad-definity commented on PR #59706: URL: https://github.com/apache/spark/pull/59706#issuecomment-6506076182
@sunchao thanks, very useful to have these reproduced against the compiled head. Addressed in d9120db1 (replies inline): - map keys are no longer narrowed through `map_keys` (new test, row reader included); - the fresh V2 builder now gets the partially pushed data filters (new test asserting the pushed filters); - the 25 fixture-only cases are plain tests, the query-shape aggregates are deterministic, and the benchmark counts `5 * numRows` rows (results being regenerated). The ORC V1 timestamp and ORC V2 positional-evolution failures reproduce on current master with ordinary nested pruning and no explode (tables inline), so I suggest separate JIRAs and PRs for those; happy to send them first, or to guard the generator path here if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
