spark-test commented on PR #59910:
URL: https://github.com/apache/spark/pull/59910#issuecomment-6508816360
Thanks for the note. This review uses the diff against the merge base,
because 0593ba1adeb is the commit that registers the analyzer and optimizer
rules from #59909, plans the new operator, and makes DataFrameReader produce
ExternalLookupRelation, so the earlier code first runs through it. Some
comments are therefore anchored in files from #59908 or #59909; feel free to
address those in the PR that owns the file.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6491712824","thread_id":"conversation:6491712824","verdict_sha256":"2eb21e8edbb305a933dad9e89c726d37de58e5f0016ffc63848d35ec68dfbe1b"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
