spark-test commented on PR #59883:
URL: https://github.com/apache/spark/pull/59883#issuecomment-6512650255
Thanks for the update. The revised description now names `ComplexTypeSuite`
for the 33-test run and says only interpreted hash lookups returned the wrong
NULL, since generated results were already correct. That matches the code: the
old `-0.0` hash differed from the `0.0` hash only in bit 31, which the bucket
mask drops, so the `hashKeyOnDriver`/`genHash` change leaves generated buckets
and results unchanged. Both earlier description suggestions are addressed.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6485180555","thread_id":"conversation:6485180555","verdict_sha256":"13bc2bc0a8f13651eb3fc9dcacde51d89eb120c941e1fc0d5be27cb6c10057ac"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
