HwangDongJun commented on PR #58861: URL: https://github.com/apache/spark/pull/58861#issuecomment-6511753066
@dongjoon-hyun This is the follow-up to the stall we discussed on #58216, where we only documented the existing drop metric. Since my first request on 9/29 I have added a check for each repair piece and fixed two tests that did not actually cover what they claimed to, and the CI is green. I also ran it on a real `local-cluster` with dynamic allocation: a stage whose submission event was dropped needed 0 executors before the change and 4 after it. The change is larger than the documentation one (about 190 lines of non-test code), so my question is whether a change like this is something you would want in `ExecutorAllocationManager`, and if so, how you would prefer it to be split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
