cloud-fan commented on PR #59630:
URL: https://github.com/apache/spark/pull/59630#issuecomment-6515034437
Thanks for the update. I checked e3e43d9656c. Candidate unions are now fresh
copies, so a rejected candidate leaves the input union untouched. Broadcast
probes backed by requirement shuffles, stages or adaptive reads now need
keepJoinBranches. The recorded-repartition check runs only on the push-down's
own proposals. An unset enabled flag now follows the custom cost evaluator
setting. This review raises one related cost question, about how a rewritten
union is counted once all of its pushed-down inputs have become query stages;
it is under Decision challenges.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6407368872","thread_id":"conversation:6407368872","verdict_sha256":"3e8febb23918757ca150c4722b1c9dc886490b9509809c986e163ebe64e247cd"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
