srielau commented on PR #59868: URL: https://github.com/apache/spark/pull/59868#issuecomment-6515489815
On the decision challenge (recounting parse_sql spans): I took the smaller step in 3132e3adfe4. Each statement is counted once and that count is reused for `length`, the fallback origin `stopIndex`, and the widening bound. `charStarts` still walks the batch once for 1-based starts; that scan is a different range (gaps in the original text) and is not the same value. Carrying code-point start/length on `PositionedSqlStatement` from the splitter still looks like follow-up. It is a broader API change than this bugfix and does not change results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
