sarutak commented on PR #59743: URL: https://github.com/apache/spark/pull/59743#issuecomment-6569739062
Thanks, @jzhuge. The changes look good to me. One small thing before this is merged: could you update the "How was this patch tested?" section of the PR description to include the new test? The current bullet "an extension listed in both configs is applied once (de-duplicated with last-win)" describes the earlier test, which does not distinguish last-win from first-win; the new test is the one that pins the last-win order and the user's repeats. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
