sankalpsthakur commented on PR #949: URL: https://github.com/apache/spark-kubernetes-operator/pull/949#issuecomment-6570298995
thanks, addressed all 10 in 51082d1. on 6, i switched back to histograms as you suggested in the previous review: the new `NanosHistogram` is exported in seconds by its type, without the name heuristic and without the timer series, so the metrics keep their 1.0 names and the guide item got shorter. details inline. CI on the fork for 51082d1: https://github.com/sankalpsthakur/spark-kubernetes-operator/actions/runs/41355400315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
