Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6876#discussion_r32751957
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
    @@ -215,4 +227,15 @@ public String mkString(String sep) {
       public String mkString(String start, String sep, String end) {
         return toSeq().mkString(start, sep, end);
       }
    +
    +  /*
    +   * Returns hash code based on bytes in `arr`
    +   * */
    +  protected int bytesHashCode(byte[] arr) {
    +    int hash = 0;
    +    for (int i = 0; i < arr.length; i++) {
    +      hash = hash * 37 + (int)arr[i];
    +    }
    +    return hash;
    --- End diff --
    
    Good idea, we should use that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to