linhongliu-db commented on PR #59962: URL: https://github.com/apache/spark/pull/59962#issuecomment-6586163754
Addressed the review in bdf667fcb5a: - Applied the Connect scalafmt rules and verified formatting. - Added the migration-guide entry and updated the PR description for the exception/SQLSTATE changes, including the legacy dialect fallback and vendor diagnostics on the cause. - Log and swallow statement-close failures so cleanup preserves binding/batch failures and allows a successful write to commit; added regression tests for each case. - Aligned both Connect message channels with the projected condition, added the plain source-next SQLException regression, and moved write coverage into JdbcWriteExceptionSuite. Local validation passed: 46 JDBC/H2/interruption tests (one existing ignored test), 6 Connect error tests, and 38 error-catalog tests, plus SQL/Connect scalastyle and SQL API/Connect scalafmt checks. The UI failure on the previous head was a timeout scanning Scala files in the CSP test; the new push will rerun it with the full CI workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
