Raviston6296 commented on PR #60013:
URL: https://github.com/apache/spark/pull/60013#issuecomment-6573988868
Thanks for working on SPARK-60646! A few things to fix before this can pass
CI:
1. `python/pyspark/pandas/series.py` has a syntax error: there's an extra
`)` after the `.alias(psdf._internal.data_spark_column_names[0])` line, so
`pyspark.pandas` fails to import (`SyntaxError: unmatched ')'`).
2. `dev/sparktestsupport/modules.py` adds
`pyspark.pandas.tests.diff_frames_ops.test_fillna` and
`pyspark.pandas.tests.connect.diff_frames_ops.test_parity_fillna`, but those
files aren't in this PR. Either add them, with a test for the
different-DataFrame branch, which isn't covered yet, or drop those two lines.
3. In `test_fillna_series_same_frame`, `psser.fillna(psser.y, ...)` /
`pser.fillna(pser.y, ...)` will raise `AttributeError`, since a Series has no
`y`. I think you meant `psdf.y` / `pdf.y`.
4. The new doctest output looks misaligned: pandas would print `0 10.0` /
`1 2.0` (see the `5 6.0` example just above).
5. Minor: `with_new_columns({new_scol}, ...)` passes a set; a list
`[new_scol]` matches the rest of the code.
Also, could you update the title to `[SPARK-60646][PS] ...` and fill in the
PR description template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
