SavicStefan commented on code in PR #59928:
URL: https://github.com/apache/spark/pull/59928#discussion_r4445058686
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionSuite.scala:
##########
@@ -100,7 +102,9 @@ class VariantExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
val a = createArray[Byte](SIZE_LIMIT, 'a'.toByte)
val hugeMetadata = bigVersion ++ Array[Byte](2, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 1, 1, 0, 0, 1) ++
a ++ Array[Byte]('b')
- check(Array(primitiveHeader(TRUE)), hugeMetadata,
"VARIANT_CONSTRUCTOR_SIZE_LIMIT")
+ val sizeLimitParams = Map("sizeLimit" -> "16 MiB")
Review Comment:
The 128 MiB value is only observable outside a test JVM, so checking it here
would mean forking a process or exposing the factory just for the test. The
existing assertions pin the parameter to the enforced SIZE_LIMIT, so I'd leave
it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
