gaogaotiantian commented on PR #59366: URL: https://github.com/apache/spark/pull/59366#issuecomment-6592385293
I'm fine with the `test_connect_plan` change, but I don't like a new file just for `test_connect_conf`. Do we have existing tests covering the code for the connect conf? I don't think it's necessary to have a whole new file just for these coverage. Also I'd like to have less mock stuff for coverage test - the test scenario should be as real as possible. We should try to use the public APIs in tests to cover more code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
