dongjoon-hyun commented on PR #59965: URL: https://github.com/apache/spark/pull/59965#issuecomment-6595710138
Thank you for the review, @viirya ! I addressed the inline comments in 0a3dd82c527 and replied in each thread. About the two points in the review: - **A legacy config:** Added `spark.sql.legacy.useCurrentConfigsForGeneratedColumn` (internal, default `false`). With it, a write reads the text under its own session as in 4.3, and CREATE and REPLACE TABLE no longer reject a text that the session reads differently. Both migration entries mention it, and a test covers it. - **Capturing the DDL's configs:** I'd like to keep it out of this PR. It needs a new field in `GenerationExpression`, which is connector API since 4.3.0, and every catalog has to round-trip it. A table created before, or one from a catalog that drops the field, still needs the reading of this PR. So this PR is the floor that captured configs would build on, and it fixes 4.3.0 without a new connector API. I'd do the capture separately, together with SPARK-60453 for CHECK constraints. I also rebased this PR onto the master branch to resolve the conflict in the migration guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
