dwsmith1983 commented on PR #60056: URL: https://github.com/apache/spark/pull/60056#issuecomment-6609720655
Thanks @MaxGekk, you're right, and that's the worse half of the bug. It wasn't just the bounds: anything whose fraction rounds up as a double came back one too high, like `0.999999999999999999` turning into `1`. I've reworded the description, the JIRA and the migration note to lead with that, and added a few far-from-the-bounds cases to the tests (`0.999999999999999999`, `12345.99999999999999` and friends). They all return the next integer on master. On the 4.3.0 SUID, good find. I put it in its own PR, #60062, to keep this one about the cast. While I was there I checked the published 4.0.5, 4.1.4, 4.2.1 and 4.3.0 jars, and 4.3.0's `Decimal` is the only new one. Its fields are the same as before, so it just needs the transition. One thing to keep in mind: all three PRs touch the `Decimal` entries, so whichever lands last will need to bump `localSuid` on both of them. Also fixed the scaladoc, pulled `intValue()` into a local, and corrected the digit count in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
