wayne-x-wang commented on PR #60116: URL: https://github.com/apache/spark/pull/60116#issuecomment-6654596838
@Raviston6296 Thanks for the detailed review. I'll move the regression tests into DDLSuite so they run against both the in-memory and Hive catalogs, update the CreateTableLikeCommand scaladoc, and remove the redundant V1 source-list override. Preserving the source view's default collation makes sense as well. I'll add a regression test using a view with DEFAULT COLLATION UTF8_LCASE, including checking that a string column added to the cloned table inherits that collation. I'll keep the V2 behavior out of this PR and leave it for a separate follow-up, since it needs its own investigation and tests around the connector contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
