cloud-fan commented on PR #59828:
URL: https://github.com/apache/spark/pull/59828#issuecomment-6663981452
Thanks for the update. On CREATE FUNCTION: agreed that the name-based check
is too strict for every function, and SPARK-60806 is the right place for the
general fix. The concern here is narrower. Under the default resolution order
the built-in owns `json_array(json_array(1))`, and master accepts a persistent
function with that body even when a temporary `json_array` exists, because
master builds the nested form directly as the built-in and the check never
inspects it. With this PR the same body fails with INVALID_TEMP_OBJ_REFERENCE,
as do VALUE and colon `json_object` bodies with a nested constructor, so this
review still raises it. On shadowing nested clause-free calls, see the Decision
challenges section of this review.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6571175139","thread_id":"conversation:6571175139","verdict_sha256":"7e5e8ac95419c2e46c30559d8d64a7dc25f5935dc865da58cbaca89b712baaa0"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
