spark-test commented on code in PR #60045:
URL: https://github.com/apache/spark/pull/60045#discussion_r4463654681
##########
.github/workflows/build_main.yml:
##########
@@ -25,13 +25,72 @@ on:
- '**'
jobs:
+ check-commit-count:
+ name: Check commit count
+ if: github.repository == 'apache/spark' && github.ref ==
'refs/heads/master'
+ runs-on: ubuntu-slim
+ permissions:
+ contents: read
+ outputs:
+ should-run: ${{ steps.count.outputs.should-run }}
+ steps:
+ - name: Check out the full branch history
+ uses: actions/checkout@v6
Review Comment:
**Nit (P3):** SPARK-59585 moved every workflow and composite action to
`actions/checkout@v7`, so this step is now the only checkout on v6 and the
repository has two major versions to track. v7 changes behavior only for fork
checkouts in `pull_request_target` and `workflow_run` events, so this
push-triggered checkout behaves the same on v7:
```suggestion
uses: actions/checkout@v7
```
**Verification:**
- **Inspection:** Every actions/checkout reference in the repository's
workflows and composite actions uses major version v7, with no v6 or older pin
remaining.
- **Behavior:** On an apache/spark master push, the sampling job still
checks out the pushed commit and reports the same commit count and should-run
decision that it reported with the previous action version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
