stevomitric commented on PR #60059: URL: https://github.com/apache/spark/pull/60059#issuecomment-6664826707
Thanks @uros-b for the review! 1. for migration note, dropped the `charVarcharAsString` rollback, pointed to `CAST(t.c AS STRING) AS k` instead, and noted that later inserts into such a CTAS table are now length-checked. 2. Added that permanent views created by an earlier version keep their stored STRING type until recreated with `CREATE OR REPLACE VIEW` / `ALTER VIEW ... AS`. Verified by dropping the CHAR key from a view's stored schema: `WHERE k = 'ab'` returns no rows until the view is recreated. 3. Fixed the version history: inside a LATERAL subquery all three forms were affected in every earlier version. PR description updated the same way. 4. Tests renamed to SPARK-60876. 5. added new tests in `CharVarcharTestSuite` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
