dbtsai opened a new pull request, #287:
URL: https://github.com/apache/spark-connect-rust/pull/287

   ### What changes were proposed in this pull request?
   
   Follow up on #166 by referencing the hashing byte/blob limit constants in 
the helper documentation and interpolating the file-upload fixture's 
`chunk_size` in its failure diagnostic.
   
   ### Why are the changes needed?
   
   Future limit or fixture-size edits should not leave duplicated numbers in 
the documentation or diagnostic. This addresses two minor findings from the 
post-merge review of SPARK-60942.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   - `git diff --check` and Python syntax parsing passed.
   - Python AST comparison confirms the assertion message is the only 
executable-source change; Rust source is identical after excluding 
documentation comments.
   - Evaluated the diagnostic with 32 KiB and 64 KiB fixture values; it reports 
the corresponding byte count.
   - Genuine local Claude Code reviewed the complete follow-up patch, verified 
both fixes, and found no correctness or blocking issues. Its two optional 
wording nits were assessed and retained as nonblocking tradeoffs.
   
   This PR remains a draft because Cargo/rustdoc, Rust unit tests and full 
integration compilation, formatting, Clippy, native-extension tests, API 
introspection and official live parity checks could not run: no usable Rust 
toolchain or private Python extension/dependencies are installed in this 
environment. The attempted Cargo checks failed before Cargo launched. No new 
runtime or CI pass is claimed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (GPT-6); reviewed with Claude Code 2.1.314 using 
configured model `system.ai.claude-fable-5-1`.
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to