Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6848#discussion_r32775409
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1421,10 +1421,10 @@ abstract class RDD[T: ClassTag](
       /**
        * Save this RDD as a SequenceFile of serialized objects.
        */
    -  def saveAsObjectFile(path: String): Unit = withScope {
    +  def saveAsObjectFile(path: String, conf: JobConf = new 
JobConf(sc.hadoopConfiguration)): Unit = withScope {
         this.mapPartitions(iter => iter.grouped(10).map(_.toArray))
           .map(x => (NullWritable.get(), new 
BytesWritable(Utils.serialize(x))))
    -      .saveAsSequenceFile(path)
    +      .saveAsSequenceFile(path, None, conf)
    --- End diff --
    
    nit: I would do `saveAsSequenceFile(path, conf = conf)` instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to