Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113300714
@kayousterhout, Thanks for reviewing this PR. I agree that we should be
more defensive moving forward. I think the right next step (no pun intended) is
to [Update ShuffleBlockFetcherIterator.next to close previous stream when
returning a new one](https://issues.apache.org/jira/browse/SPARK-8454). That
would prevent any ShuffleReader from leaking memory or file handles.
@rxin I just pushed an update that I believe addresses all your comments.
Let me know if I missed anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
