Github user megatron-me-uk commented on a diff in the pull request:
https://github.com/apache/spark/pull/6262#discussion_r32792241
--- Diff: python/pyspark/rdd.py ---
@@ -704,7 +704,12 @@ def pipe_objs(out):
out.write(s.encode('utf-8'))
out.close()
Thread(target=pipe_objs, args=[pipe.stdin]).start()
- return (x.rstrip(b'\n').decode('utf-8') for x in
iter(pipe.stdout.readline, b''))
+ result = (x.rstrip(b'\n').decode('utf-8') for x in
iter(pipe.stdout.readline, b''))
+ pipe.wait()
--- End diff --
Yes I see the problem now. I think it can be overcome by wrapping the
pipe.wait and subsequent lines in a second iterator. Something like:
```
from itertools import chain
...
def check_return_code(pipe):
pipe.wait()
if pipe.returncode:
raise Exception("Pipe function `%s' exited "
"with error code %d" % (command, pipe.returncode))
else:
return None
result = (x.rstrip(b'\n').decode('utf-8') for x in
chain(iter(pipe.stdout.readline, b''), iter(check_return_code, None)))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
