Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6889#issuecomment-113370880
LGTM, it will be better if you could add some tests for it, and add
examples in the doc. Right now it's hard to tell what's the type of these
parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
