Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6882#discussion_r32825688
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
---
@@ -173,7 +171,20 @@ case class ScriptTransformation(
}
outputStream.close()
}
- }).start()
+ }, "Thread-ScriptTransformation-Feed").start()
+
+ // Consume the error stream from the pipeline, otherwise it will be
blocked if
+ // the pipeline is full.
+ new Thread(new Runnable() {
--- End diff --
Instead of writing another thread class, can you use `RedirectThread`,
which is used for the same purpose elsewhere, to dump the data?
Also, it's slow to read a byte at a time here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
