Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6864#discussion_r32844987
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
@@ -70,7 +71,7 @@ private[sql] case class InsertIntoHadoopFsRelation(
relation.paths.length == 1,
s"Cannot write to multiple destinations:
${relation.paths.mkString(",")}")
- val hadoopConf = sqlContext.sparkContext.hadoopConfiguration
+ val hadoopConf = new
Configuration(sqlContext.sparkContext.hadoopConfiguration)
--- End diff --
Do we need this? We already do `val job = new Job(hadoopConf)` below. BTW,
we need to add comment to explain `new Job` will clone the conf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
