Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6721#discussion_r32848403
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
 ---
    @@ -205,6 +208,34 @@ case class ToRadians(child: Expression) extends 
UnaryMathExpression(math.toRadia
       override def funcName: String = "toRadians"
     }
     
    +case class Bin(child: Expression)
    +  extends UnaryExpression with Serializable with ExpectsInputTypes {
    +
    +  val name: String = "BIN"
    +
    +  override def foldable: Boolean = child.foldable
    +  override def nullable: Boolean = true
    +  override def toString: String = s"$name($child)"
    +
    +  override def expectedChildTypes: Seq[DataType] = Seq(LongType)
    +  override def dataType: DataType = StringType
    +
    +  def funcName: String = name.toLowerCase
    --- End diff --
    
    This is not needed, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to