Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113598503
Should we also add a REPL test case which uses `HiveContext` to ensure the
isolated classloader plays well with code generation? I know that `HiveContext`
only exists on driver side while code generation happens on executor side, what
I'm thinking is there might be chances that they shoot at each other in local
mode where everything happens in a single JVM. This can be done in a separate
PR since this is a hot fix.
Otherwise looks good, but I'm not super familiar with the whole code
generation stuff though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
