Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6759#discussion_r32857375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -117,4 +124,27 @@ object DateUtils {
0L
}
}
+
+ /**
+ * Return the number of 100ns (hundred of nanoseconds) since epoch from
julian day
+ * and nanoseconds in a day
+ */
+ def fromJulianDay(day: Int, nanoseconds: Long): Long = {
+ // use integer to avoid rounding errors
--- End diff --
It looks like we're using longs here to avoid the rounding errors, not
integers, so maybe we should update this comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
