Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5748#issuecomment-113608869
@jkbradley I just had a proper look at this after a long time.
I think this PR succeeds in preventing the huge Word2Vec map while
constructing the Word2Vec model.
However, if the user provides a Word2Vec map by himself to construct the
Word2Vec model (in the future, since Word2Vec model is marked as
private[mllib]), it creates a huge array of size numWords * numDims. Are we
okay with that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
