Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6863#issuecomment-113648473
That is a good point. Then make two different examples one for Java and
Scala.
BTW, I would like to have this for 1.4.1, so gotta merge soon. So I think I
will merge this, and you can make another PR with the same JIRA to add the
new examples.
On Fri, Jun 19, 2015 at 1:29 PM, Cody Koeninger <notificati...@github.com>
wrote:
> The word count examples don't have any need of accessing offsets.
>
> Wouldn't it be better to have separate examples? I don't want someone
> thinking they need to do all this typecast hoop jumping just to get a word
> count
>
> On Fri, Jun 19, 2015 at 3:16 PM, Tathagata Das <notificati...@github.com>
> wrote:
>
> > So the JIRA was about updating the examples actually. Its great that you
> > have updated the docs AND the tests, but it would ideal if the examples
> > DirectKafkaWordCount and JavaDirectKafkaWordCount are updated to show
how
> > the offset ranges can be accessed. Since you have updated the tests,
mind
> > updating the examples as well?
> >
> > â
> > Reply to this email directly or view it on GitHub
> > <https://github.com/apache/spark/pull/6863#issuecomment-113630096>.
>
> >
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/6863#issuecomment-113632591>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
