Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6759#discussion_r32872239
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -21,19 +21,31 @@ import java.sql.Timestamp
import org.apache.spark.SparkFunSuite
-class DateUtilsSuite extends SparkFunSuite {
+class DateTimeUtilsSuite extends SparkFunSuite {
- test("timestamp") {
+ test("timestamp and 100ns") {
val now = new Timestamp(System.currentTimeMillis())
now.setNanos(100)
- val ns = DateUtils.fromJavaTimestamp(now)
+ val ns = DateTimeUtils.fromJavaTimestamp(now)
assert(ns % 10000000L == 1)
- assert(DateUtils.toJavaTimestamp(ns) == now)
+ assert(DateTimeUtils.toJavaTimestamp(ns) == now)
List(-111111111111L, -1L, 0, 1L, 111111111111L).foreach { t =>
- val ts = DateUtils.toJavaTimestamp(t)
- assert(DateUtils.fromJavaTimestamp(ts) == t)
- assert(DateUtils.toJavaTimestamp(DateUtils.fromJavaTimestamp(ts)) ==
ts)
+ val ts = DateTimeUtils.toJavaTimestamp(t)
+ assert(DateTimeUtils.fromJavaTimestamp(ts) == t)
+
assert(DateTimeUtils.toJavaTimestamp(DateTimeUtils.fromJavaTimestamp(ts)) == ts)
}
}
+
+ test("100ns and julian day") {
--- End diff --
Are there any other inputs that are worth testing here? It wouldn't be
super hard to fuzz this using the invariant that some of these methods should
be inverses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
