Github user yu-iskw commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6791#discussion_r32882080
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
    @@ -465,6 +465,36 @@ private[python] class PythonMLLibAPI extends 
Serializable {
       }
     
       /**
    +   * Java stub for Python mllib LDA.run()
    +   */
    +  def trainLDAModel(
    +      data: JavaRDD[LabeledPoint],
    --- End diff --
    
    Umm, it is a little difficult to decide which is the better. The different 
point between yours and mine from the users point of view are :
    
    - Each row type is an array or a tuple
    - Feature data type is array or DenceVector/SparceVector
    - Does yours support sparce vector?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to