Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6910#discussion_r32882795
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala
---
@@ -53,7 +53,7 @@ private[flume] class SparkAvroCallbackHandler(val
threads: Int, val channel: Cha
// Since the new txn may not have the same sequence number we must guard
against accidentally
// committing a new transaction. To reduce the probability of that
happening a random string is
// prepended to the sequence number. Does not change for life of sink
- private val seqBase = RandomStringUtils.randomAlphanumeric(8)
+ private val seqBase = UUID.randomUUID().toString.substring(0, 8)
--- End diff --
Ah, this is a Type 4 random UUID so it only relies on random numbers and
not something less random, such as the date / time or a MAC address or
namespace, so this seems fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
