Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6918#issuecomment-113727568
Thanks for fixing this; the test looks good to me, but I think we might
want to preserve the old behavior of also performing error cleanup when
Throwables are thrown (i.e. by using the `success` flag idiom that I used
before, but perhaps with a comment this time to explain what's going on).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
