Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/791#issuecomment-43706083
@mridulm Thanks very much for your comment! I think a big difference is:
earlier code call BlockManager#dropFromMemory within putLock, but now we call
it in parallel, we have to check it carefully.
About the try-catch, I agree using `finally` would be better, I will work
on it.
About the `entry.getSize`, I found I need `pair.getValue` twice, so I
extract it into `val entry = pair.getValue`. Is that right?
By the way, what do you think of define the dropping flag as volatile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
