Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32884828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+ if (!o.isInstanceOf[Row]) {
+ return false
+ }
+
+ val other = o.asInstanceOf[Row]
+ if (length != other.length) {
+ return false
+ }
+
+ for (i <- 0 until length) {
+ if (isNullAt(i) != other.isNullAt(i)) {
+ return false
+ }
+ if (!isNullAt(i)) {
+ val o1 = apply(i)
+ val o2 = other.apply(i)
+ if (o1.isInstanceOf[Array[Byte]]) {
+ // handle equality of Array[Byte]
+ val b1 = o1.asInstanceOf[Array[Byte]]
+ if (!o2.isInstanceOf[Array[Byte]] ||
+ !java.util.Arrays.equals(b1, o2.asInstanceOf[Array[Byte]])) {
+ return false
+ }
+ } else if (o1 != o2) {
+ return false
+ }
--- End diff --
Should we abstract this column compare logic into a method? So that we
don't need to write it again for code generation...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
